Remove usage of async/await from code until the library switches over entirely

manfredsteyer / angular-oauth2-oidc

Support for OAuth 2 and OpenId Connect (OIDC) in Angular.

MIT License

1.88k stars 688 forks source link

Remove usage of async/await from code until the library switches over entirely #481

Open FabienDehopre opened 5 years ago

FabienDehopre commented 5 years ago

I found that there is still some code that use the async/await coding style in your base code (https://github.com/manfredsteyer/angular-oauth2-oidc/blob/286366939ed4ad02050d0c2d0f6a4b63f2dcc7ff/projects/lib/src/token-validation/validation-handler.ts#L45) This is related to #329

jeroenheijmans commented 5 years ago

I've slightly reworded the title (hope that's appropriate!), as you seem to suggest (correctly, IMHO) that until the guidance from #329 gets changed we should not include any async/await - and remove this occurence (not in the least to prevent dragging along polyfills just for one instance of these keywords)...