manga-download / haruneko

Prototype of HakuNeko based on NW.js + TypeScript
https://haruneko-docs.pages.dev
152 stars 31 forks source link

Download manager list on right side #314

Closed zeoint closed 1 year ago

zeoint commented 1 year ago

0

Sheepux commented 1 year ago

I was already working on it. It should be ready by the end of the week.

Sheepux commented 1 year ago

here is what i started working on: downloadprogress

This progress is a button that will open the DownloadTask manager.

I have 3 UI options:

  1. use a modal to open the download manager (easy)
  2. add the download manager as a content (of the content pannel)
  3. add an extra column before the content pannel

I'll go for 1 for now. Could be improved

zeoint commented 1 year ago

I have 3 UI options:

  1. use a modal to open the download manager (easy)
  2. add the download manager as a content (of the content pannel)
  3. add an extra column before the content pannel

I understood 2. and 3. but not 1.

I'll go for 1 for now. Could be improved

A couple suggestions,


Its subjective, but the two line download / progress bar in the above gif is confusing. Wouldn't it be better to add one of the below ones?

Title Description
Single Line Progress Bar Like the one in hakuneko, it only has single bar which is sufficient (imo)
Numerical % Numerical % of the current chapter downloaded or total chapters downloaded
Downloaded Chapters / Total Chapters 1 / 3 Chapters downloaded, 2 / 3 Chapters downloaded, and so on...
Downloaded Pages / Total Pages If multiple downloads, then show the downloading chapter pages only.
Example - User is downloading 3 chapters and each chapter has 100 pages, then show chapter that is being download and pages being downloaded.
1 / 100, 2 / 100, so on.
Sheepux commented 1 year ago

Modal: a form of popup https://carbon-components-svelte.onrender.com/components/Modal

Sheepux commented 1 year ago

A couple suggestions,

  • Green Tick and Green Color for progress after download completed = No error, Downloads completed. ( Example - Final Green tick and green color in the above gif).
  • Red Cross mark or exclamatory mark and red color for progress after download compoleted = Error, Download error / Missing pages, etc.

Already the case: https://carbon-components-svelte.onrender.com/components/ProgressBar#error-status

Its subjective, but the two line download / progress bar in the above gif is confusing. Wouldn't it be better to add one of the below ones?

Title Description Single Line Progress Bar Like the one in hakuneko, it only has single bar which is sufficient (imo) Numerical % Numerical % of the current chapter downloaded or total chapters downloaded Downloaded Chapters / Total Chapters 1 / 3 Chapters downloaded, 2 / 3 Chapters downloaded, and so on... Downloaded Pages / Total Pages If multiple downloads, then show the downloading chapter pages only. Example - User is downloading 3 chapters and each chapter has 100 pages, then show chapter that is being download and pages being downloaded. 1 / 100, 2 / 100, so on.

I could introduce a "small version" option of the download summary but that'll be later. First i need to get the full page one designed

Sheepux commented 1 year ago

First rework commited with a modal. I'll close this issue for now but it doesn't mean that it won't get improved later. Let me know what you think.

note: the engine doesn 't currently have the pause feature on tasks (will come later).

zeoint commented 1 year ago

Honestly, the pop-up looks cool. Great work.