search

manga-download / haruneko

Prototype of HakuNeko based on NW.js + TypeScript
https://haruneko-docs.pages.dev
147 stars 31 forks source link

Detect Flatmanga AntiDdoSS #691

Closed MikeZeDev closed 3 months ago

MikeZeDev commented 4 months ago

relevant commit : https://github.com/manga-download/haruneko-proprietary/commit/2f544fd4cd9b27e5b0426af34ae1c561668c1fb6

Dont want to put more code on Flatmanga PR and since its touching obfuscated code for the other repo i think its better done in a separate PR.

ronny1982 commented 3 months ago

Only generic detections are supposed to be added to AntiScrapingDetection.ts Add it to the related file as done in e.g., MangaLink

MikeZeDev commented 3 months ago

Only generic detections are supposed to be added to AntiScrapingDetection.ts Add it to the related file as done in e.g., MangaLink

As is it, it would be related to 6 websites, i think its enough.

If i add it to all affected websites it would create useless copies of the code (that would be executed nonetheless) . I could add it to one website but , which one?

Hence ive choosen the global file.

ronny1982 commented 3 months ago

It must only be added once not six times. Technically it doesn't matter where it is added, but semantically it should be added in a file that is related to the bypass e.g., The FlatManga decorator file.