mangal-interactions / mangal-api

mangal RESTful API services - documentation at
https://mangal-interactions.github.io/mangal-api/
MIT License
0 stars 1 forks source link

malformed doi for reference https://mangal.io/api/v2/reference/24 #54

Open jhpoelen opened 4 years ago

jhpoelen commented 4 years ago

Through Global Biotic Interactions <> Mangal Integration (see https://github.com/globalbioticinteractions/globalbioticinteractions/issues/81), I found a malformed doi for reference https://mangal.io/api/v2/reference/24 :

{"id":24,"doi":"110.1007/bf00240204","first_author":"thomas m. lancraft","year":"1991","jstor":null,"pmid":null,"bibtex":"@article{Lancraft_1991, doi = {10.1007/bf00240204}, url = {https://doi.org/10.1007%2Fbf00240204}, year = 1991, month = {jun}, publisher = {Springer Nature}, volume = {11}, number = {3}, author = {Thomas M. Lancraft and Thomas L. Hopkins and Joseph J. Torres and Joseph Donnelly}, title = {Oceanic micronektonic/macrozooplanktonic community structure and feeding in ice covered Antarctic waters during the winter ({AMERIEZ} 1988)}, journal = {Polar Biology}}","paper_url":"https://doi.org/10.1007%2Fbf00240204","data_url":"https://globalwebdb.com/","created_at":"2019-02-23T18:01:29.998Z","updated_at":"2019-02-23T18:01:29.998Z"}
SteveViss commented 4 years ago

Thanks @jhpoelen, I will have a look at this one tomorrow.

jhpoelen commented 4 years ago

Other malformed dois include:

local   found malformed doi [0.2307/3565022]
local   found malformed doi [110.1007/bf00240204]
local   found malformed doi [110.3354/meps084101]
local   found malformed doi [NA]
BenMerSci commented 4 years ago

The 4 malformed dois listed above were fixed! Thank you for pointing out @jhpoelen!

jhpoelen commented 4 years ago

@BenMerSci wow that's fast! Just curious - how do you keep track of your data versions?

jhpoelen commented 4 years ago

btw - found another malformed DOI:

found malformed doi [2433/156407]
SteveViss commented 4 years ago

@jhpoelen, we have a daily dump of the DB but this is not perfect. Do you know some tools for that?

jhpoelen commented 4 years ago

There's many versioning techniques. I am keeping track of all datasets coming into GloBI using content hashes via https://github.com/globalbioticinteractions/elton . I've also seen folks use git to version their datasets. Perhaps something for another thread.

Also, note that I've setup a mangal integration check at https://travis-ci.org/globalbioticinteractions/mangal . You'll find warning like malformed doi in the basic report at the end of the travis log. Scheduled to run weekly.

BenMerSci commented 4 years ago

Hi @jhpoelen, The last malformed DOI that you found ([2433/156407]) was actually the NA one in your first post that I "fixed". It seems though that it isn't, but I don't really understand. If I go for example on https://www.doi.org/ and search the article with [2433/156407], I get the right page to download the associated article. Is it because it doesn't lead directly to the article itself?

jhpoelen commented 4 years ago

According to the DOI specs, a DOI must starts with 10.. This tells me that 2433/156407 is a malformed DOI.