search

mangerij / ferret

Open-source MOOSE application "Ferret" for parallel mesoscale simulations of ferroic and related electronic materials
7 stars 6 forks source link

Clean up main.C and explicitly register dependent app #325

Closed MengnanLi91 closed 7 months ago

MengnanLi91 commented 7 months ago

Adapt to the new changes in MOOSE(https://github.com/idaholab/moose/pull/25994)

MengnanLi91 commented 7 months ago

@mangerij Could you help me review this patch PR?

MengnanLi91 commented 7 months ago

Hi @mangerij, could you let me know what the failure messages are for the tests? I don't have access to that information.

cticenhour commented 7 months ago

I can see it - It's because the PR isn't based on devel.

Oops....I just changed this, and it seems to have mucked up your history a little bit. If you don't mind, I can fix this for you since it was my fault.

MengnanLi91 commented 7 months ago

I can see it - It's because the PR isn't based on devel.

Oops....I just changed this, and it seems to have mucked up your history a little bit. If you don't mind, I can fix this for you since it was my fault.

Oh oh I didn't realize it. Yeah, go ahead. Thanks a lot!

cticenhour commented 7 months ago

@mangerij the current failure here is unrelated and was fixed in the master branch (see 0966066).

Running the tests locally, there are also two unrelated diffs with a newer MOOSE version (as of Jan 15):

    DIFF FAILED (EXODIFF) test:msca.gs
    DIFF FAILED (EXODIFF) test:msca.PAdw

Both are relatively small diffs, but might need some local exploration, tolerance adjustment, and/or re-golding.

mangerij commented 7 months ago

@cticenhour @MengnanLi91 Hi, I'll give a look later today at the changes to main.C. (sorry for the delay, I don't have GH notifs sent to my work email -will change)

MSCA diffs are slightly alarming. Are you sure they are actually diffing? I checked a recent PR and Ferret seems to be building and passing tests no problem.

https://civet.inl.gov/job/2011110/

cticenhour commented 7 months ago

I am on an Apple Silicon Mac, so there is likely just a platform related diff here. I can double check on a Linux system later this morning when I get to the office.

mangerij commented 7 months ago

Im going to go ahead and merge this. I have not recompiled my MOOSE/Ferret in some time but I trust that it is not going to do anything crazy...