search

mangiucugna / json_repair

A python module to repair invalid JSON, commonly used to parse the output of LLMs
https://pypi.org/project/json-repair/
MIT License
826 stars 48 forks source link

Add direct file loading #22

Closed ajmeese7 closed 6 months ago

ajmeese7 commented 6 months ago

Issue #21

What is the current behavior?

Users can only pass JSON they already have in string form.

What is the new behavior?

Does this introduce a breaking change?

Other information

I made some other changes to the project not directly related to my feature, I get carried away sometimes :)

Feel free to change as you see fit.

mangiucugna commented 6 months ago

Hi @ajmeese7, I really can't approve this PR this way. There are too many unrelated changes that have nothing to do with the issue you raised.

I appreciate the effort and I think that in general the change you want to make looks good, but please limit the PR to the changes needed to push this new feature so I can review and run the test suite.

Also I should have added to the instructions to not edit pyproject.toml since I do that when I release the library and choose the version

Thank you again for the contribution