search

manglemix / Trokara

A modular package for developing terrestrial characters
MIT License
44 stars 8 forks source link

Ignore screenshots and a few warnings #1

Closed aaronfranke closed 4 years ago

aaronfranke commented 4 years ago

This prevents screenshots from being imported, and I also silenced a few warnings. See this article for more information: https://docs.godotengine.org/en/latest/tutorials/assetlib/uploading_to_assetlib.html

By the way, why is the EOL setting set to CRLF? It's a good practice to use LF everywhere, it takes up less disk space and it's what Godot uses when creating new files.

manglemix commented 4 years ago

Oh dear, I think CRLF was a mistake. I believe I was trying to set it to LF because my github desktop was getting messed up

aaronfranke commented 4 years ago

I pushed a 2nd commit changing it to eol=lf, and I also took the liberty of changing README.md to be formatting-script-friendly (The backslash \ is an alternative to two spaces for escaping newlines and it doesn't require trailing spaces).

manglemix commented 4 years ago

Thank you for reviewing my package, I'm trying to open up more to the community, and I appreciate people going through my work to improve it

aaronfranke commented 4 years ago

If you want another suggestion, consider using a better Git client. GitHub Desktop is not very good. Personally I use GitKraken (it's free for public repos) and I also made a video explaining how to use it; https://www.youtube.com/watch?v=0XKy8YpP5Ww