mangonetwork / mangopy

This repository contains code for processing all-sky images generated by the Mid-latitude All-sky-imager Network for Geophysical Observations (MANGO), a project funded by the National Science Foundation.
GNU General Public License v3.0
6 stars 2 forks source link

[DISC]: loosen up the requirements.txt #8

Closed asreimer closed 3 years ago

asreimer commented 5 years ago

The requirements for this package seem overly strict, for example, numpy >=1.16. Are these really necessary? Perhaps we can loosen the restrictions a bit?

ljlamarche commented 4 years ago

This probably is excessively strict. Is there any rule of thumb for how to handle these things, or should I just see how old of a numpy version I can have before things start to break?

asreimer commented 3 years ago

Here's some recommendations:

ljlamarche commented 3 years ago

I ended up doing this in d584b4aa13672211d2854ba70a9cc9cae1eace9a as part of getting mangopy to build on readthedocs. I adopted all of @asreimer's suggestions above except for cartopy. When installing cartopy via pip, you have to first manually install several dependancies. This isn't necessary when installing cartopy with conda. If cartopy is included in requirements.txt, it produces build errors. The README does specify that cartopy must be installed BEFORE mangopy, so I think it's fine to leave cartopy out of requirements.txt, and just make the installation instructions:

  1. Install cartopy
  2. Install mangopy