search

mangos / MaNGOS

This is the master Information repository for MaNGOS
http://getmangos.eu
3.03k stars 1.36k forks source link

Server Chat: Make Sense Damn You! #73

Closed bugeyedcreepy closed 12 years ago

bugeyedcreepy commented 12 years ago

Sorry for the "Death by a Thousand Papercuts", is there a better way to commit small changes to lots of files?

VladimirMangos commented 12 years ago

You _DON'T must modify sql updates. This's useless. Sql updpates exist only for single thing: apply modification from mangos.sql/etc to real used DB state without need reset DB for specific commit (that happens for existed in repo sql updates in past). So make sense only modification mangos.sql part + creating new sql update for apply mangos.sql modification to real existed DB without revision guards in its.

Also this meaning that mangos.sql modification patch can't be simple merged and must be prepared by dev as normal commit with rev. number and etc.

bugeyedcreepy commented 12 years ago

Ahh, Thanks for that! :D I can redo this easily enough, should I just adjust the main sql/mangos.sql and a corresponding updated .sql.... and should I try my hand at adding such an update as a file in sql/updates?? I'm aware of the method but not crystal clear on it.

Schmoozerd commented 12 years ago

well, if you want to take work from the developer, add an sql update file located to sql/updates/ A proper name for this file would be 00000_00_mangos_mangos_string.sql or 99999_00_mangos_mangos_string.sql (or something similar - just be sure to pick a number far away from used numbers)

actually to be really correct, you should add sqls for mangos_mangos_string.sql and mangos_command.sql :)

bugeyedcreepy commented 12 years ago

SWEET! All over it :D

umm, any way to undo this commit or part thereof? Just "Close Pull Request"?? I'll start on revising this shortly.

Schmoozerd commented 12 years ago

Do not mixup stuff in commits :)

One commit to fix engrish, and maybe clarify text Another commit to remove unused entries

bugeyedcreepy commented 12 years ago

sweeeeeet, what Schmoozered said, I've fixed another pull request so will resubmit. :)