mangosArchives / Mangos-One-server-old

This repo has been moved to https://githubs.com/mangosone/server
http://getmangos.eu/
GNU General Public License v2.0
95 stars 54 forks source link

Devastate & Sunder Armor #28

Open Ve1vet opened 12 years ago

Ve1vet commented 12 years ago

Devastate on hit don't apply Sunder Armor, just refresh it.

https://gitorious.org/atlantiscore/atlantiscore/commit/560ce730203d74aebba9b97e5c9f8300cd993512 - here is fix.

You can also remove hack fix on mangos WOTLK:

if (!sunder || sunder->GetStackAmount() < sunder->GetSpellProto()->StackAmount) m_caster->CastSpell(unitTarget, 58567, true);

It just cast the last rank of sunder armor & don't even matter have player the last rank of that spell or not.

DomGries commented 12 years ago

https://gist.github.com/1303471 ... I made that patch long ago however the most obvious problem was that it caused damage twice and plays the animation twice.

Also I think 58567 is the general effect for all sunder armor spells on wotlk - not sure though

Ve1vet commented 12 years ago

Hmmmm... I don't have any clue why when you test your fix it caused damage twice. Maybe problem was in some different place, for instance target map. I tested on my server, works as it should. About animation. It plays animation twice because first it cast Devastate & then instantly cast Sunder Armor. Anyway, now it works perfectly.

pyza666 commented 12 years ago

Vovk's patch adds sunder armor effect but it doesn't stack up, its just apply max available rank of sunder armor and next use of devastate just refreshes the cooldown.

Ve1vet commented 12 years ago

It work like it should. I already answered for your question why. You should have rage for Devastate + Sunder Armor = Like it should.

pyza666 commented 12 years ago

I dont know much about coding but is it possible to make another spell effect like sunder armor but without rage cost and attach it to devastate ?