search

mangosArchives / Mangos-One-server-old

This repo has been moved to https://githubs.com/mangosone/server
http://getmangos.eu/
GNU General Public License v2.0
95 stars 54 forks source link

[Spell] Shadowform #31

Open Lillecarl opened 12 years ago

Lillecarl commented 12 years ago

If you cast a dot within shadowform, then leave shadowform it will keep ticking 15% extra shadow dmg until its over. If you cast a dot while not in shadowform then enter shadowform, dot will keep ticking as normally if not reapplied.

fr1nge commented 12 years ago

Are you sure this is a bug? Afaik the bonus damage of any periodic spell is calculated based on the buffs of the caster before spell is casted. Discussion: http://us.battle.net/wow/en/forum/topic/1921989466

Lillecarl commented 12 years ago

No im not sure ^^, I just reported from what one of my "devs" (friends) said ^^,

Ve1vet commented 12 years ago

Lillecarl, right. This is big big bug of mangos. No dynamic recalculate damage on change spd/ap/stats/auras/aura holders. For spd/ap it fixes very easy. But for stats, at this moment i have no idea how. You can see any movie from TBC, for example warrior. When stance changes, damage from dots recalculates. And so on. In trinity core this things works perfectly.

fr1nge commented 12 years ago

Damage needs to be recalculated just when the target changes auras, aka if warriors change stances would get -/+10% increased damage. But it has nothing to do with the caster changing auras, the DoT damage is calculated based on the stats the caster had at the moment of casting.

Ve1vet commented 12 years ago

Omg... No comments.

Lillecarl commented 12 years ago

It is a different issue, this was regarding target auras, not caster auras

Ve1vet commented 12 years ago

fr1nge, just wrong. Thats it. Lillecarl, i tell you the power of that bug. If only auras of target will be refreshed. Take resto druid with ~1600 bonus healing. Take two trinkets which at use gives additional bonus healing. Blow trinkets & cast lifebloom 3 stacks + Rejuvenation. And then just refresh them even if auras of that trinket fades. Then you take resto druid with full sunvell gear + all enchantment without that trinkets. And cast 3 lifeblooms + rejuvenation. And you become shocked. The difference between this druids about ~1000 bh, but druid with sunwell gear not even close for that druid with trinkets.

Lillecarl commented 12 years ago

We need video proof so we can see what is actually right. Lets open this and start searching for videos

fr1nge commented 12 years ago

Please read these issues from TC: https://github.com/TrinityCore/TrinityCore/issues/5959 https://github.com/TrinityCore/TrinityCore/issues/1127 https://github.com/TrinityCore/TrinityCore/pull/6314

Ve1vet commented 12 years ago

After some research i agree with that fact that dots/hots don't recalculate at every tick or with change stats caster. But they must recalculate at refresh/reapply, at changing target auras such as Shadowform, warrior stances, wound poison( for hots ) etc. including you as target yourself. At this moment nothing works.