mangosArchives / Mangos-One-server-old

This repo has been moved to https://githubs.com/mangosone/server
http://getmangos.eu/
GNU General Public License v2.0
95 stars 54 forks source link

Dual wielding #38

Closed fr1nge closed 12 years ago

fr1nge commented 12 years ago

There is something really strange about how dual wielding works atm on One. I tested on rogues but might be the same with warriors and shamans. Basically you get and extra white hit whener you are damaging a target. Something like: MH oh oh MH oh oh MH oh oh MH MH oh MH oh oh MH MH oh MH oh MH oh oh....

Visually the character is acting normal, but somehow there are extra attacks triggered that have nothing to do with any talent or spell, they are just pure white hits.

Ve1vet commented 12 years ago

It's not strange. This is horrible truth :D In one commit, i don't remember when was added support for OH weapons for mobs. Of course it was implemented in unit.cpp ( put there reset timer for Oh ). But in player.cpp they forget delete reset timer. And now for player Oh-timer resets to time faster. Here is commit which correct this. https://gitorious.org/atlantiscore/atlantiscore/commit/afc54284312f5e38b2684e73e78162fc032c656f Just comment or delete strings in player.cpp. Thats it.

fr1nge commented 12 years ago

How am i not surprised, was thinking something like that happened :p Anyway thanks for the input, works like a charm. Patch plus additional code style cleanups here: https://github.com/fr1nge/one.server/commit/69db65a42db4c7a575e08cd7d3e94edf5ce71e46