search

mangosArchives / Mangos-One-server-old

This repo has been moved to https://githubs.com/mangosone/server
http://getmangos.eu/
GNU General Public License v2.0
95 stars 54 forks source link

Big bunch of fixes #4

Closed iorlas closed 13 years ago

iorlas commented 13 years ago

W/o this fix, lifebloom ignores heal bonus and always ticks like w/o player gear. So, i can write sql update file, but i think it'll be easier for you just to put it in next sql update bunch :)

iorlas commented 13 years ago

By the way, how to ignore other commits and to say Github "i have really cloned to upstream repo!" ? I imagine it will be next month, after over 20 merges +_+

iorlas commented 13 years ago

And Swiftmend spell(id 18562). It needs to remove Regrowth or Rejuvenation spell on Swiftmend spellcast.

iorlas commented 13 years ago

And to Swiftmed fix. As i see, in mangos/mangos you're using different function. So, i think it'll be better. https://github.com/mangos/mangos/blob/master/src/game/SpellEffects.cpp#L3747

iorlas commented 13 years ago

Mangle now works like it needed. All bleeding effects now works with it. In before, mangle logic was placed in Unit::SpellDamageBonusTaken, but bleeding effects will never be a "spell damage". So, we can just move logic to Unit::MeleeDamageBonusTaken with merging existing code(shred, i mean). I tried to find some code for Mangle bleed effects in mangos/mangos, but "grep -R" gives only not interesting codelines. Perhaps, mangos/mangos has same problem and this fix can be ported into latest repo.

VladimirMangos commented 13 years ago

all cases reviewed