SpellAuraHolder issue

[Undergarun]

http://pastebin.com/KrKJ81WP http://pastebin.com/BsDnK1J3 http://pastebin.com/gQNVLPWT

Without drop usage LOCKED SpellAuraHolderPtr.

Need check those crashes before test Locked SpellAuraHolderPtr removal.

[Undergarun]

Second one spell issue:

http://pastebin.com/HKudEbFn

Both happens just once, but now with higher MapUpdate.Threads working, those weird crashes appears.

[rsa]

this crush with locked SpellAuraHolderPtr or with not locked (commit https://github.com/mangosR2/mangos/commit/12f12a52b324ff4c849bf8e166e703cb5365bad9)?

[Undergarun]

With locket SpellAuraHolderPtr!! Master version. No testing commit implemented.

[rsa]

please, link your string Unit.cpp:8200 with master line numbers. possible problem in constructions like SpellAuraHolderMap const& victimAuras = pVictim->GetSpellAuraHolderMap(); for (SpellAuraHolderMap::const_iterator itr = victimAuras.begin(); itr != victimAuras.end(); ++itr) without SmartPtr lock - after last lock changes requires more accurate operations.

[Undergarun]

// custom scripted mod from dummy AuraList const& mDummy = owner->GetAurasByType(SPELL_AURA_DUMMY); for(AuraList::const_iterator i = mDummy.begin(); i != mDummy.end(); ++i) { SpellEntry const _spell = (_i)->GetSpellProto(); //Fire and Brimstone if (spell->SpellFamilyName == SPELLFAMILY_WARLOCK && spell->GetSpellIconID() == 3173) { if (pVictim->HasAuraState(AURA_STATE_CONFLAGRATE) && (damageInfo->GetSpellProto()->SpellFamilyName == SPELLFAMILY_WARLOCK && damageInfo->GetSpellProto()->GetSpellFamilyFlags().test<CF_WARLOCK_INCINERATE, CF_WARLOCK_CHAOSBOLT>())) { DoneTotalMod = ((_i)->GetModifier()->m_amount+100.0f) / 100.0f; break; } } }

[Undergarun]

The only diff between master and my repo is Armory Support.

[Undergarun]

Other low chance crash in Auras

http://pastebin.com/C4GCAKcf

[Undergarun]

http://pastebin.com/zyK4e8Eb

[Undergarun]

No new crashes. Thank you.