search

mangosR2 / mangos

Production (stable and testing) versions of current mangosR2 v2 server (World of Warcraft: Wrath of the Lich King, 3.3.5a client).
http://mangosr2.2x2forum.com/
GNU General Public License v2.0
175 stars 78 forks source link

Rogue poisons proc #277

Closed michalpolko closed 12 years ago

michalpolko commented 12 years ago

Rogue poisons can proc many times from single rogue spell cast. Example macro:

/cast Sinister Strike /stopattack

You will have Sinister Strike cast and proc poison, often double or sometimes even triple procs, where it should only proc once from one spell.

rsa commented 12 years ago

may be proc internal cooldown need? or i don't understand this problem...

michalpolko commented 12 years ago

I checked if poison can proc self by .cast poison_spell but didn't proc, so problem may be in proc from different effects of 1 spell (Sinister Strike has 3 effects, 2 are school dmg, maybe problem is here) or something else. There can not be internal cooldown for spell because same poison should proc also from second weapon (in dual wield) so there must be some "second execution" of code related to proccing poisons.

P.S. Problem is huge for players, currently on my server rogues with Killing Spree kill in 3s every class ;x

rsa commented 12 years ago

i check this, not confirm. only one proc from every dagger (this correct, as i know). PS i repair envenom :) now rogues more powerful.

michalpolko commented 12 years ago

I'll check if this is my fork's problem then.

michalpolko commented 12 years ago

get a slow weapon (some sword 2.60) and apply wound poison on it. only main hand weapon

use macro: /cast Sinister Strike /stopattack

result: http://imageshack.us/f/35/wowscrnshot091811133259.jpg/

check in 13:32:54 - 2 procs of wound poison but i used sinister sttrike once and have only 1 weapon and didn't use autoattack. around 90% of attacks from spell proc poison twice (sometimes even 3 times!)

check in the same way if this bug exists for You.

Oh and almost forgot: this appears on mangosR2/mangos, not only on my fork

michalpolko commented 12 years ago

OK, the problem is here: every spell effect that is targeting creature can proc WeaponItemEnchants, this doesn't occur for poisons only probably, but for some other enchants as well. Of course proc should occur only once for a spell.

rsa commented 12 years ago

please, remove aura 674 and try again. PS your have proc from "unarmed hand attack" in this case...

michalpolko commented 12 years ago

You want me to rip my left hand off? ;D I am using only one attack - from main hand. This can be seen in combat log. Unlearning dual wield changed nothing. Eviscerate has only 1 effect applying to target creature and it proccs only 1 time.