search

mangosR2 / mangos

Production (stable and testing) versions of current mangosR2 v2 server (World of Warcraft: Wrath of the Lich King, 3.3.5a client).
http://mangosr2.2x2forum.com/
GNU General Public License v2.0
175 stars 77 forks source link

Demonic Circle: Summon #349

Open jluis859 opened 13 years ago

jluis859 commented 13 years ago

http://www.wowwiki.com/Demonic_Circle:_Summon

This has a bug, if you use again the spell it will to close the demonic circle and spends mana when it happens, it should renew the place of the demonic circle. Now it's a awful bug because you lose time closing and putting again the demonic circle and spending mana =/

You can watch videos and it always renew the place of it without closing it.

michalpolko commented 13 years ago

It works this way because spell wasn't truly fixed, it is hacked in clean mangos afaik.

there were problems with stacking, one aura replaces another and portal disappears on removing of aura, maybe must check what kind of unapplying of the aura we are dealing with.

jluis859 commented 13 years ago

the problem is here: http://paste2.org/p/1639134

I tried to leave only: target->CastSpell(target, 62388, true) but it becomes a demonic circle without time and without aura, but it teleport without buff and renew it. http://paste2.org/p/1639141

If I put it (target->CastSpell(target, 62388, true)) after removing the aura, it doesnt work, it does the same thing without this line. http://paste2.org/p/1639144

This code is in SpellAuras.cpp

Any idea?

jluis859 commented 13 years ago

I was testing with diferents ways to fix this and I found that with this code http://paste2.org/p/1639441 it works properly, it does respawn very well and it disapears after 6 minutes, but it doesnt show the aura for the spell 48018(demonic circle: Summon) with 6 minutes. After the second time that I use the spell, the buff "disapear" but it still works underground and let me use it.

I tried to add the aura with this target->_AddAura(48018,360000); in some part of the code but I got a big crash xD

Any ideas to develop a proper fix?

rsa commented 13 years ago

48018 - not real DC aura, it's only dummy check. real spell - 62388 - absent in DBC and may be not fully correct emulated.