too many talents applied

[tibbi]

There is a pretty major bug, people say that it appeared like 2-3 days ago on gc (broken on r2 too, not sure since when). Bug is, that some talents are applied, even if the player doesnt have them on any spec. Once you learn them, they stay with you, even after unlearning them. Its only about passive auras i think. For example I mean Blood Gorged, a deep DK blood talent. Once you take it, it stays with you for ever. Can be seen with .list auras. Since on r2 it might be hard to reach that talent tho, as you have only 25 talent points, another example is Fiery Payback, a deep fire mage talent. It updates your pyroblast casting time and cd even if you dont have the talent already, just once had. I will do more research soon, about which commit caused it.

[raynar]

I confirm this, is a major bug :(

[rsa]

it's exists on clean mangos also over 1,5 year. find source - be corrected...

[tibbi]

from what i found so far, at some spells its only the highest rank unapplying. So for example, at Blood Gorged, which as 5 ranks, after reseting the talents, rank 4 is still active. Its most likely connected to the fact, that it has EffectTriggerSpell0 and EffectTriggerSpell2 filled too. Both these effects drop just to rank 4, arent unlearned. Doing more tests now.

[tibbi]

think i found a fix, Its proly not the nicest, but works fine to me :) commited it on my repo, check https://github.com/tibbi/tibbi_mangos/commit/ab798cdf7b564a15109c99b18d00c61b09259b6a

[rsa]

seems good, but who

for (int k = 0; k <= 2; ++k)

but not standart way

for (uint8 k = 0; k < MAX_EFFECT_INDEX; ++k)

???

[raynar]

so...to master? :D

[rsa]

yes (in standart form). Even if the problem is not in this place, so the check will not be superfluous.

[tibbi]

ok, Ill commit to master, in standard way :p I usually forget about such stuff...

[raynar]

great work.