mangosR2 / mangos

Production (stable and testing) versions of current mangosR2 v2 server (World of Warcraft: Wrath of the Lich King, 3.3.5a client).
http://mangosr2.2x2forum.com/
GNU General Public License v2.0
175 stars 78 forks source link

Some bugs about Totems #705

Open Tiquihit opened 12 years ago

Tiquihit commented 12 years ago
  1. Totems should ignore the walls. They are auras and therefore do not need the line of sight for its effect.

--What happens if Grounding Totem is not in line of sight to someone casting a spell at the Shaman/whoever in party?

Will the spell not get redirected, or go through wall... or totem will just get destroyed? Vorph on 2008/06/26 (Patch 2.4.2) --It doesn't have to be in LOS of the enemy spellcaster, as long as the shaman has the buff from the totem. The offensive spellcast will shoot through the wall to the totem, destroying it. http://www.wowhead.com/spell=8177/grounding-totem#comments

--Tremor, Healing stream, Stoneskin- they're all auras. LoS does not apply to auras. [/quote] http://forums.hydramist.tv/showthread.php?5399-Totems-and-LoS

http://www.threadmeters.com/qeQsQP/Give_Totems_LOS_Restrictions/ (Cry)

--Tremor is already a drop and forget aoe fear dispel, requiring no gcds to cleanse any fears as long as it's up. If it gets killed, then it's still better than other dispels for breaking fear considering when you drop it [b]you don't need los[/b] and it's aoe. http://www.arenajunkies.com/topic/149615-tremor-fix/pagest20

  1. Totems are getting into the walls when you cast near to them and, therefore, totems immortals
  2. Grounding Totem is eating friend's penance and Dispel of priests don't destroy it

Regards and thanks :)

rsa commented 12 years ago

I just do not understand where is the problem and that the proposed fix? almost all spells of totems so ignore LOS (by attributes in DBC).

Tiquihit commented 12 years ago

For these totems do not ignore the line of sight --> Tremor (you have to cast it every time you step), Grounding (If a wall doesn't redirect anything) and Stoneclaw (Often gets into the wall and doesn't gives you the shield buff)

If you want I can do a video

tst12 commented 12 years ago

2 current check "is spell positive" need additional check "m_caster->IsFriendlyTo(m_target)"

Tiquihit commented 12 years ago

want the video? or something?

Venom commented 12 years ago

player report 42 level ALIANCE Elemental Shaman :

i only learned 2 totems [Earth Totem] and [Fire Totem] but using this spell http://www.wowhead.com/spell=66842 [call of the elements] summoning all 4 totems. even if i learned only 2 of them..... tested and seen by myself :D

but this is strange. becouse i have seen HORDE player totems worked fine....

rsa commented 12 years ago

in last sources auto-summon not learned totems impossible. suppose problems with displaying spells in player spellbook (possible after GM learn/unlearn commands).

Tiquihit commented 12 years ago

Another bug: Judgements of paladin shouldn't destroy grounding totem

"From Paladins - Hammer of Justice (Does not ground Judgements)." http://www.wowhead.com/spell=8177/grounding-totem#comments

http://www.threadmeters.com/hYRBJy/Judgements_dont_remove_grounding_totem/

Tiquihit commented 12 years ago

2months without any answer T_T

Xencha7 commented 12 years ago

Please, this is too important about shamans :S

rsa commented 12 years ago

any work on this issue has reason only after #770 finish.

Tiquihit commented 12 years ago

now we have dynamic vmaps, can be fixed? :D

Xencha7 commented 12 years ago

Much time bug... we need it to play good :S

Tiquihit commented 12 years ago

Still bug:

  1. Totems are getting into the walls when you cast near to them and, therefore, immortal totems.
  2. Grounding Totem is eating friend's penance and Dispel (redirect, not in the totem) of priests don't destroy it.
  3. Improved Devouring plague (http://www.wowhead.com/spell=63626/improved-devouring-plague) should destroy totems (not the dot, the inicial damage) but it shows inmune.
  4. Grounding totem doesn't ignore LOS.
rsa commented 12 years ago

Grounding totem require some rewrite... After last commit, totems not may appears in wall/GO. Improved Devouring plague - also is DOT. need info source from off, where this need exclude from rules...

Tiquihit commented 12 years ago

With totems works fantastic, thanks!!

Tiquihit commented 12 years ago

In Ruins of Lordaeron arena, totems get into the tomb. The rest work perfectly.