search

mangosR2 / scriptdev2

MangosR2 universal Script Library, compartible with all mangosR2 cores (v2, 3, 4 and possible later).
http://mangosr2.2x2forum.com/
GNU General Public License v2.0
82 stars 47 forks source link

need possible revert #143

Closed softbest closed 12 years ago

softbest commented 12 years ago

Hi

I think that https://github.com/mangosR2/scriptdev2/commit/b6a0ee5059dd9213cd4d101f01962dfa3b340711 need a revert. I think that isn't neccesary and it do problem in windows and R2 not use branch 400

michalpolko commented 12 years ago

Yes, this causes linking problems in vc90 project, I've been trying to find the way to fix this but I guess I'm not good at it ;D Including DBCStructure.h doesn't solve this. Disabling pch extends build time for too long, I didnt even check this. Any ideas anybody?

Zakamurite commented 12 years ago

https://github.com/mangos-three/server/commit/c800505246530f0b0f220fc1dbc85754fd3ceff3 ?

michalpolko commented 12 years ago

This doesn't help :<

softbest commented 12 years ago

I think the best solution is revert commit because only it's for Mangos 400

Reamer commented 12 years ago

@softbest That's no real solution, better fix linking problems. I think this wrapper functions are good, we can work with more enum

rsa commented 12 years ago

10 min ago compiled (over cmake+VC2012RC). no problem with linking... commit needed for future use. may remove in own branches.

michalpolko commented 12 years ago

What Zakamurite linked didnt help, but this way https://github.com/mangosR2/mangos/commit/04c528993d58ab458e920115a511dbb78b24485d helped ;] maybe in mangos-three code is written in other order.

rsa commented 12 years ago

as i think, your try make with PCH :)