mangrovedao / mangrove-bots

🌴 Bots for the Mangrove ecosystem
4 stars 3 forks source link

Cleaner bot, cannot clean offer made by failing offer bot #13

Open peterMangrove opened 1 year ago

peterMangrove commented 1 year ago

Is your feature request related to a problem? Please describe. The failing offer bot post offers, but does not have the funds for the actual offers when they get matched. The cleaning bot tries to snipe offers, by taking 0% of the offer. But this does not trigger a makerTransferFail, because transferring 0 amount of tokens is okay.

Describe the solution you'd like The cleaner bot should be able to clean offers, where the maker does not have the funds. This can be done by either giving the cleaning offer bot owner address, a small amount of different tokens or using a "whale" (another address, that has a lot of tokens) and then trying to snipe on behalf that address. MgvCleaner has the functionality called collectByImpersonation. This would require that whale to approve MgvCleaner to use it tokens. Since MgvCleaner can never successfully snipe any offers, this would not be dangerous for the whale.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

lnist commented 9 months ago

@Louis-Amas is this fixed? (The failing offer bot does not exist anymore, but the issue of what cleaning bot could not clean)