search

mangrovedao / mangrove.js

🌴 SDK for building applications on Mangrove and bots using the SDK
https://mangrove.exchange
Other
31 stars 12 forks source link

MgvOracle should not be exposed through mangrove.js #249

Closed dontrolle closed 2 years ago

dontrolle commented 2 years ago

Is your feature request related to a problem? Please describe. MgvOracle is an internal functionality, not intended for access by market-makers or -takers. Therefore, it does not belong in mangrove.js as it is currently setup. It does belong in a future tentative mangrove-admin.js, which has been discussed being split off from the current mangrove.js.

Describe the solution you'd like Remove access to MgvOracle from mangrove.js, and update updategas-bot to access MgvOracle directly.

Describe alternatives you've considered Create mangrove-admin.js, and move relevant functionality (including access to MgvOracle) to there.

dontrolle commented 2 years ago

To clarify: With the following setup we're looking for the described solution, not the suggested alternative.