search

mangstadt / ez-vcard

A vCard parser library for Java
Other
398 stars 92 forks source link

Dpon janky registrar fixes #108

Closed daekpon closed 4 years ago

daekpon commented 4 years ago

I ended up having to fork and modify our vcard parsing library in order to gracefully parse all the crappy registrar json that whodat ends up getting.

mangstadt commented 4 years ago

Thanks for bringing this to my attention! It's interesting to see how jCard is being used in the wild.

I see that you deleted the branch. Are these jCard parsing problems no longer an issue for you?

I would be interested in seeing examples of the kinds of jCards you are getting. I'm hesitant to integrate such deviations from the jCard spec into the ez-vcard codebase, but if a lot of people are doing these sorts of things, then it might be worth looking into.

daekpon commented 4 years ago

yeah - sorry - I intended to PR into my forked branch, not your main repo. that’s why I deleted the branch.

thanks for the lib - it’s been great. I’m using it to parse RDAP whois records. Unfortunately many domain registrars don’t adhere to spec and return all sorts of crappy json. here’s one example that provides the vcard properties in their own proprietary format:

https://www.namesilo.com/rdap/domain/virginiabeachlandlord.info

Other times, we see them using “vcards” instead of “card”, or including the properties not in a nested array, like this one does: https://rdap.namecheap.com/domain/LD-0700.COM

really, it’s like wack-a-mole trying to accomodate all the crappy registrar responses :)

On Jul 29, 2020, at 8:09 AM, Michael Angstadt notifications@github.com wrote:

Thanks for bringing this to my attention! It's interesting to see how jCard is being used in the wild.

I see that you deleted the branch. Are these jCard parsing problems no longer an issue for you?

I would be interested in seeing examples of the kinds of jCards you are getting. I'm hesitant to integrate such deviations from the jCard spec into the ez-vcard codebase, but if a lot of people are doing these sorts of things, then it might be worth looking into.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mangstadt/ez-vcard/pull/108#issuecomment-665722511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCAI7BVW5UAGGENU6KIETR6A3TJANCNFSM4PKVUVVA.

mangstadt commented 4 years ago

Thanks for the examples. Sounds like a headache for sure!