search

mangstadt / ez-vcard

A vCard parser library for Java
Other
399 stars 92 forks source link

Improve TelUri parsing performance #38

Closed blendmaster closed 8 years ago

blendmaster commented 8 years ago

More upstream parity from fullcontact/ez-vcard.

codecov-io commented 8 years ago

Current coverage is 76.10%

Merging #38 into master will decrease coverage by -0.03% as of a802efc

@@            master    #38   diff @@
=====================================
  Files          203    203       
  Stmts         7374   7374       
  Branches      1141   1144     +3
  Methods                         
=====================================
- Hit           5614   5612     -2
- Partial        237    239     +2
  Missed        1523   1523

Review entire Coverage Diff as of a802efc

Powered by Codecov. Updated on successful CI builds.

mangstadt commented 8 years ago

Thanks for the idea, @blendmaster. I went a step further and removed calls to String.split(), since this method uses a regular expression as well. See commits 0e232d59bd18e620c07dd77c75b0e2eaa23c1e2e and 389ef2b1f0a2dea53099b4b231f6b6293364a656.