Closed jniesen closed 8 years ago
Everything looks great here. The PR comment says not ready to merge. Is this still the case?
Yes, that's still the case. I'm gonna smoke test it to make sure that I can assume role using AWS_ROLE_EXTERNAL_ID
and then I'll update the origiinal comment.
I smoke tested a scenario where I needed to use AWS_ROLE_EXTERNAL_ID
and one without. In both scenarios I was able to successfully assume the role.
I bumped only the minor version since all changes are backwards compatible.
I also made a commit to update the load path in exe/awssume
. This mimics the spec_helper's load path and allows us to require 'awssume'
like it would be done after a gem install. This makes smoke testing locally easier than building and then gem install from the pkg dir.
This should be good to merge now.
Awesome! Thanks for the work on this new feature. Merging.
Opening a pull request for a suggested new feature.
For to come in this thread.
Not ready to merge.