search

manheim / awssume

rubygem for running a command with AWS AssumeRole credentials
MIT License
25 stars 11 forks source link

Enable the use of an External ID for assuming a role #4

Closed jniesen closed 8 years ago

jniesen commented 8 years ago

Opening a pull request for a suggested new feature.

There are scenarios where you might want to [use an external id][aws_ext_id] in a condition on your assume role policy. For such cases, the gem will look for the AWS_ROLE_EXTERNAL_ID variable in your environment. If this variable is set the value will be sent allong in the STS Assume Role request.

For to come in this thread. Not ready to merge.

reppard commented 8 years ago

Everything looks great here. The PR comment says not ready to merge. Is this still the case?

jniesen commented 8 years ago

Yes, that's still the case. I'm gonna smoke test it to make sure that I can assume role using AWS_ROLE_EXTERNAL_ID and then I'll update the origiinal comment.

jniesen commented 8 years ago

I smoke tested a scenario where I needed to use AWS_ROLE_EXTERNAL_ID and one without. In both scenarios I was able to successfully assume the role.

I bumped only the minor version since all changes are backwards compatible.

I also made a commit to update the load path in exe/awssume. This mimics the spec_helper's load path and allows us to require 'awssume' like it would be done after a gem install. This makes smoke testing locally easier than building and then gem install from the pkg dir.

This should be good to merge now.

reppard commented 8 years ago

Awesome! Thanks for the work on this new feature. Merging.