search

manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.
https://manheim-c7n-tools.readthedocs.io/
Apache License 2.0
45 stars 25 forks source link

fix unicode encoding error when running under py3 #10

Closed jantman closed 5 years ago

jantman commented 5 years ago

Description

There's a bug we hadn't hit in our internal code, where policygen dies when running under python3 because it tries to use a string regex on a unicode/bytes value. This PR fixes that.

Testing Done

Unit tests.

codecov-io commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   57.43%   57.43%           
=======================================
  Files           8        8           
  Lines        1170     1170           
  Branches      212      212           
=======================================
  Hits          672      672           
  Misses        498      498
Impacted Files Coverage Δ
manheim_c7n_tools/policygen.py 100% <100%> (ø) :arrow_up:
manheim_c7n_tools/version.py 100% <100%> (ø) :arrow_up:
manheim_c7n_tools/utils.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78b8c59...bf0d430. Read the comment docs.