search

manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.
https://manheim-c7n-tools.readthedocs.io/
Apache License 2.0
45 stars 25 forks source link

fix dryrun-diff errors #11

Closed jantman closed 5 years ago

jantman commented 5 years ago

Description

When running dryrun-diff locally this morning in a Python3 venv, I found 2 bugs in it: one related to Python3 and one related to running the standalone dryrun-diff entrypoint vs running it as a step in manheim-c7n-runner.

Testing Done

Ran locally; bugs fixed.

codecov-io commented 5 years ago

Codecov Report

Merging #11 into master will decrease coverage by 0.04%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   57.43%   57.38%   -0.05%     
==========================================
  Files           8        8              
  Lines        1170     1171       +1     
  Branches      212      212              
==========================================
  Hits          672      672              
- Misses        498      499       +1
Impacted Files Coverage Δ
manheim_c7n_tools/dryrun_diff.py 13.96% <0%> (-0.08%) :arrow_down:
manheim_c7n_tools/version.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b6a2fd...8eeb5a7. Read the comment docs.