manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.
https://manheim-c7n-tools.readthedocs.io/
Apache License 2.0
45 stars 25 forks source link

Fixes #18 - Handle account_id as string not number #19

Closed jantman closed 4 years ago

jantman commented 4 years ago

Description

This is a fix for #18. With this PR, we will handle all account_ids as strings instead of (incorrectly) as numbers, to stop breaking accounts with IDs that begin with zero. In the config schema we still allow numeric values and explicitly cast them to strings, in order to not break compatibility with existing config files.

Testing Done

  1. Unit tests.
  2. Ran policygen step locally against an account with an ID starting with 00. Confirmed failure on master and fix on this branch.