policygen.py requires a Github remote origin url

manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.

https://manheim-c7n-tools.readthedocs.io/

Apache License 2.0

46 stars 25 forks source link

policygen.py requires a Github remote origin url #31

Open NiteDesign opened 4 years ago

NiteDesign commented 4 years ago

policygen.py _policy_rst process is setting gitlink by calling git_html_url() This process fails if not using Github repo.

I'm bypassing this by not calling the git_html_url() within policygen.py and setting: gitlink = 'not applicable'

jantman commented 4 years ago

@NiteDesign Yeah... sorry, this project is rather opinionated when it comes to that, and it assumes you're using github. PRs are welcome for a fix, or you're always welcome to work around that as needed...

jantman commented 4 years ago

I'm labeling this issue as "help wanted". We'd be happy to accept a pull request to resolve this issue, but as it's not a feature that we'd use, we won't be implementing a fix ourselves.