manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.
https://manheim-c7n-tools.readthedocs.io/
Apache License 2.0
45 stars 25 forks source link

Implement a breakdown report on all affected policies during a dryrun #35

Closed JuubiSnake closed 4 years ago

JuubiSnake commented 4 years ago

Hi,

We'd like to make a suggestion regarding the dryrun-diff component of Manheim; currently the dryrun generates a markdown sytle comment which you can place on a PR in order to view the overall effect a policy change will have on it's respective resources.

In addition to this, it would be great to also generate a detailed report regarding the identity of the resources affected in the dryrun, for instance, which resources have been removed, added, left unchanged and so on. This way, it instills more confidence to a reviewer around changes made to a policy as they know exactly what is going to be affected.

We have already been working on this and have opened https://github.com/manheim/manheim-c7n-tools/pull/34 that introduces this feature, and would welcome your feedback.