search

manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.
https://manheim-c7n-tools.readthedocs.io/
Apache License 2.0
45 stars 25 forks source link

Install from git, to get fix for missing jsonpointer and jsonpatch deps #40

Closed jantman closed 4 years ago

jantman commented 4 years ago

Description

The mailer in this project / Docker image is currently broken because of upstream https://github.com/cloud-custodian/cloud-custodian/issues/5707 where c7n-mailer failed to declare its dependency on jsonpointer and jsonpatch, causing mailer to fail to run. This was fixed in https://github.com/cloud-custodian/cloud-custodian/pull/5708 upstream, which has been merged to master but not yet released (the release will be done whenever https://github.com/cloud-custodian/cloud-custodian/pull/5734 is merged).

This PR goes back to installing c7n and c7n-mailer from upstream git, in order to pull in this fix. Once there's a new upstream release, we'll revert these changes and bump to the latest upstream version.

Testing Done

Automated tests via tox show the install is now pulling in jsonpatch==1.25 and jsonpointer==2.0.

jantman commented 4 years ago

It looks like installing from git is causing a local install of the python cryptography module, which requires the libffi-dev and openssl-dev OS dependencies during the Docker build. Pushed a commit to fix that, as well as add a .dockerignore file to make local docker builds faster. Tested locally, Docker image now builds.