manheim / manheim-c7n-tools

Manheim's Cloud Custodian (c7n) wrapper package, policy generator, runner, and supporting tools.

https://manheim-c7n-tools.readthedocs.io/

Apache License 2.0

45 stars 25 forks source link

Fixing dryrun-diff step for inherited policies #61

Closed jleopold28 closed 3 years ago

jleopold28 commented 3 years ago

Description

Refactor dryrun-diff to only compare the dryrun results with the last live run.
- Remove logic for using git diff to find changed_policies.

Testing Done

Tested dryrun-diff when inherited policies. Dryrun-diff output shows changes to inherited policies.

Contributor License Agreement

Required for external contributors.

By submitting this work for inclusion in manheim-c7n-tools, I agree to the following terms:

The contribution included in this request (and any subsequent revisions or versions of it) is being made under the same license as the manheim-c7n-tools project (Apache v2).
My contribution may perpetually be included in and distributed with manheim-c7n-tools; submitting this pull request grants a perpetual, global, unlimited license for it to be used and distributed under the terms of manheim-c7n-tools's license.
I have the legal power and rights to agree to these terms.

codecov-commenter commented 3 years ago

Codecov Report

Merging #61 (d77daa6) into master (28c6e34) will increase coverage by 0.81%. The diff coverage is 21.42%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   60.65%   61.47%   +0.81%     
==========================================
  Files           9        9              
  Lines        1492     1469      -23     
  Branches      294      288       -6     
==========================================
- Hits          905      903       -2     
+ Misses        586      565      -21     
  Partials        1        1

Impacted Files	Coverage Δ
manheim_c7n_tools/dryrun_diff.py	`14.81% <15.38%> (+0.52%)`	:arrow_up:
manheim_c7n_tools/version.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28c6e34...d77daa6. Read the comment docs.

jantman commented 3 years ago

@jleopold28 The changes here look good to me, thanks! Can we test this internally on a few of our accounts before merging?

jleopold28 commented 3 years ago

@jleopold28 The changes here look good to me, thanks! Can we test this internally on a few of our accounts before merging?

Yeah that sounds good, thanks!

jleopold28 commented 3 years ago

@jantman Updated the docs if you want to take another look.