Make sure it support gitlab-ci urls

stokkie90 commented 2 years ago

Should fix #31

Description

Screenshot from 2022-03-11 15-38-42

Describe what this PR does or the problem that it solves. If the description is long, use one summary sentence first, then dive into the details in another paragraph.

Testing Done

What was done to test this? Paste build link(s), console output, notes, etc.

Important Notes

Optional; instructions to reviewers, plans for how to release this, dependencies in other repos, etc.

Contributor License Agreement

Required for external contributors.

By submitting this work for inclusion in manheim-c7n-tools, I agree to the following terms:

The contribution included in this request (and any subsequent revisions or versions of it) is being made under the same license as the manheim-c7n-tools project (Apache v2).
My contribution may perpetually be included in and distributed with manheim-c7n-tools; submitting this pull request grants a perpetual, global, unlimited license for it to be used and distributed under the terms of manheim-c7n-tools's license.
I have the legal power and rights to agree to these terms.

palmobar commented 2 years ago

Hi, any progress on that? I'd be interested in this PR being merged.

jantman commented 2 years ago

@stokkie90 @palmobar Apologies for letting this sit for so long. This looks simple enough to merge, thanks!

manheim-c7n-tools has 100% unit test coverage. Could you please update this PR with some unit test cases (here) for the URL patterns that you're adding support for? Thanks.

atheeque-ahmed commented 1 year ago

Hi, any updates on this issue? I'm looking forward to this PR being merged.

manheim / manheim-c7n-tools