Closed Kalekdan closed 5 years ago
@crazywolf132 - this uses a different jar to the main jar (tests using the main jar will fail offline with this change since they will not have the stdlib)
True, I didn't think of that. How about we add a test then (in tests.sh) for this jar too then?
I've added a runTestsOffline.mni which is also run using the new jar to demonstrate it passing offline
Awesome work. If you think it is ready, we are good to merge.
@crazywolf132 As long as you are happy that the normal smaller .jar without the stdlib included will no longer function offline.
Name: Fat jar including stdlib files About: Adds a gradle job to add stdlib files to the jar when building
Is your PR related to a feature request or Bug report? If applicable, please list feature request number or bug report ID.
Describe your PR A clear and concise description of what your pull request is changing or adding.
Describe intended use A clear and concise description of the intended use of the feature. Along with example code.
Is it in the form of a library
Does your PR replace an existing system If applicable, please describe how this PR changes the use of a related item.
Additional comments Add any additional comments or screenshots here.