mani2012 / PathoStat

The purpose of this package is to perform Statistical Analysis on the PathoScope generated reports files.
8 stars 9 forks source link

Remove dependency on "microbiome" #17

Closed mlbendall closed 8 years ago

mlbendall commented 8 years ago

The core microbiome functions depend on functions in https://github.com/microbiome/microbiome, which introduces a lot of additional dependencies.

ecastron commented 8 years ago

Perhaps it's not so convenient to add that one then. It's a nice to have feature, and you don't find many packages to do that type of analysis, but if it's going to burden too much pathoStat we could leave it for another future version.

mlbendall commented 8 years ago

I don't think it'll be too hard to remove, they're basically just adjusting detection/prevalence cutoffs, right? I'm just reminding myself to do it.

ecastron commented 8 years ago

I think so, it's basically core taxa detection as a function of abundance with different prevalences

mlbendall commented 8 years ago

I think the only tricky part is figuring out what those thresholds should be, because if you set it up wrong you get something like seen below. Although I'm still trying to figure out if this is because the example data is pre-filtered (for top 10 taxa) or because of the default thresholds.

screen shot 2016-07-20 at 5 16 31 pm
ecastron commented 8 years ago

It looks like they use 1 and 95% for detection and prevalence threshold, respectively. In pan genome analysis they use the same prevalence threshold for genes, i.e., being present in 95% of the genomes