search

maniacx / Battery-Health-Charging

GNU General Public License v3.0
157 stars 14 forks source link

data: mark a string translatable in settings.ui #58

Closed ghost closed 10 months ago

ghost commented 10 months ago
maniacx commented 10 months ago

Hello sabriunal. Regarding this commit.
https://github.com/maniacx/Battery-Health-Charging/commit/9f7ba3d6ef6d5dc0a1c7b32bf64b84ccb5214fd9 I merged this, since my laptop was broken and I couldnt check it. but now I am thinking why do I need this. Does it affect the extensions in anyway?

I am overriding the title of preference page here.

https://github.com/maniacx/Battery-Health-Charging/blob/9f7ba3d6ef6d5dc0a1c7b32bf64b84ccb5214fd9/preferences/thresholdPrimary.js#L47-L50

Kindly reply if we need the above commit. If not I will revert it.

ghost commented 10 months ago

Please revert, a working extension is better than broken one.

Also, It's not visible on the UI and as you said it's a placeholder and we don't need to mark it translatable.

Definitly my mistake. Sorry.