maniaplanet / game-modes

Maniaplanet scripts and resources
https://www.maniaplanet.com/
GNU Lesser General Public License v3.0
30 stars 17 forks source link

Option to turn on/off match server reconnection. #2

Closed domino54 closed 6 years ago

domino54 commented 6 years ago

Useful, when game mode creator doesn't want players to reconnect to the matches they've left (for example a battle royale match).

Match reconnection is causing major problems in HG matchmaking, where eliminated players are supposed to be transferred back from ongoing match back to the lobby, allowing them to participate in a new match, while the remaining players in abandoned server can finish their game. Currently, the player is transferred back to the match, in which they can no longer participate, instead of staying in the lobby.

My fix contains similar functions and methods as your other "settings", cutting off ReconnectToServer() method when disabled.

magnetik commented 6 years ago

Looks good to me about the interaction with the API. Not sure if a side effect can be hidden somewhere in the dark though.

domino54 commented 6 years ago

We tested this out with some players - it works! Players, who left an ongoing match were able to get a new match, while the game they've left was still going.