search

maniaplanet / manialive-lib

LIB-ONLY. See "manialive" project instead.
1 stars 4 forks source link

Problem with logging of the last error #10

Open oliverde8 opened 10 years ago

oliverde8 commented 10 years ago

Hi, we are using the $config->maxErrorCount on eXpansion and noticed that when the system stopped due to that we had a missing error message. SO just called displayAndLogError before increaseErrorCount to fix it.

also added a message to see why it has ended

I suppose this might cause a nice loop as well if the error comes from the displayAndLogError but after a short while a nice stack overflow should still stop the system XD

magnetik commented 10 years ago

I have trouble with your change as it seems that you changed the end of line so I can't pinpoint what you really changed.

It it possible for you to re issue a "clean" pull request from master?

oliverde8 commented 10 years ago

Hi, it is actually the indentation I changed :cry:

The fix is to inverse this lines : '''self::displayAndLogError($e); self::increaseErrorCount();'''

The way it is at the moment the system dies before logging the error.

I will try and do a clean pull request