search

maniaplanet / manialive-lib

LIB-ONLY. See "manialive" project instead.
1 stars 4 forks source link

Update Storage.php #5

Closed oliverde8 closed 10 years ago

oliverde8 commented 10 years ago

On a relay server the map list isn't returned. This fixes the issue with the current map being null while that information can be received

magnetik commented 10 years ago

So this caused an exception when using ManiaLive on a relay server?

oliverde8 commented 10 years ago

$this->maps[$this->connection->getNextMapIndex()] is an undefined offset, which causes an exception.

The reason for this is that the $this->connection->getMapList(-1, 0); returns only one map.

$this->connection->getNextMapIndex() seems to work fine but as there isn't the list of the maps ...

I don't know it might be a bug of the dedicated. In TMNF this works fine because you can get the list of the maps.

Oliver De Cramer E-mail : oliverde8@gmail.com Web : oliver-decramer.com http://oliver-decramer.com/

On Mon, Mar 31, 2014 at 10:58 AM, Baptiste Lafontaine < notifications@github.com> wrote:

So this caused an exception when using ManiaLive on a relay server?

Reply to this email directly or view it on GitHubhttps://github.com/maniaplanet/manialive-lib/pull/5#issuecomment-39066831 .

magnetik commented 10 years ago

Thanks :)

oliverde8 commented 10 years ago

no problem.

Oliver De Cramer E-mail : oliverde8@gmail.com Web : oliver-decramer.com http://oliver-decramer.com/

On Mon, Mar 31, 2014 at 11:03 AM, Baptiste Lafontaine < notifications@github.com> wrote:

Thanks :)

Reply to this email directly or view it on GitHubhttps://github.com/maniaplanet/manialive-lib/pull/5#issuecomment-39067228 .