search

maniaplanet / manialive

PHP controller for the ManiaPlanet Dedicated Server
GNU Lesser General Public License v3.0
9 stars 4 forks source link

$window->isVisible() or $window->isShown() ? #37

Closed magnetik closed 10 years ago

magnetik commented 10 years ago

From martin.gwendal on June 20, 2011 17:58:37

In ManiaLib\Gui\Component there is a field $visible and a method isVisible() which are supposed to be used in ManiaLive (and are indeed used in ManiaLive\Gui\Windowing\Control and in namespace ManiaLive\Gui\Windowing\Controls\PageNavigator). But in Window, a new field $isHidden and a new method isShown() appear and $visible doesn't seem to be used anymore...

Problem is now, a lot of plugins with windows use $isHidden and/or isShown()... Anyway, I think $isHidden and isShown() should be deprecated ^^

Original issue: http://code.google.com/p/manialive/issues/detail?id=37

magnetik commented 10 years ago

From melot.philippe on June 29, 2011 01:06:43

In fact, those two values are not related, in one case it's linked to ManiaLib controls, the other one is a value to hide a window in ManiaLive, it's two different things.

Status: WontFix
Owner: melot.philippe

magnetik commented 10 years ago

From martin.gwendal on June 29, 2011 02:40:30

It's still a matter of visibility. BTW, the comment of isVisible() is "This is used by ManiaLive." so I don't see any problem to use it for ManiaLive's windows ^^

And if those two values are not related, why using posX, posY, posZ, sizeX, and so on ? There are linked to ManiaLib controls but used for windows ;)