maniaplanet / manialive

PHP controller for the ManiaPlanet Dedicated Server
GNU Lesser General Public License v3.0
9 stars 4 forks source link

addComponent and removeComponent take different types #38

Closed magnetik closed 10 years ago

magnetik commented 10 years ago

From maximeraoust on July 19, 2011 19:32:03

in ManiaLive\Gui\Windowing\Container we have:

function addComponent(Drawable $component) function removeComponent(Component $component)

and Component and Drawable are not related (inheritance-wise).

Is it normal? You can stuff like: add a Drawable, and then you cannot remove it because it's not a Component.

Original issue: http://code.google.com/p/manialive/issues/detail?id=38

magnetik commented 10 years ago

From martin.gwendal on November 09, 2011 09:47:52

Status: Fixed