search

manicdigger / manicdigger

Manic Digger - a multiplayer block-building voxel game, Minecraft clone
http://manicdigger.sourceforge.net/
Other
326 stars 78 forks source link

Unnecessary rendering of lava on map bottom #171

Open exemd opened 9 years ago

exemd commented 9 years ago

Lava

It's caused by this line:

https://github.com/manicdigger/manicdigger/blob/d4f3a445a5a0fae4cb47e8a232ebd8b502c103cf/ManicDiggerLib/Client/Misc/TerrainChunkTesselator.ci.cs#L360

TobiMob commented 9 years ago

I don't think that line is the core of the problem. I think the problem is that Lava is handled as a fluid. Maybe it should be handled as a solid block for tesselation, since it has a default size and is not transparent.

croxxx commented 9 years ago

Maybe. Shouldn't really be a problem anyway as I modified the world generator to generate Adminium at the bottom layer. Modifying Lava to be treated a soldid by renderer could cause display glitches when swimming in it...

Hm, maybe Lava could be displayed the same way as water?

TobiMob commented 9 years ago

@croxxx : Yea, thats right. I missed the part where people would like to swim in lava. Two thing should be needed for lava to work like water. 1) Here the tt == 8 should be replaced with a IsWater(...)

2) The if/else branch that exemd posted above needs to be fixed. It is used for the case below. A waterblock has a lowered waterblock next to it, but a solid block above. But this fails to check if its neighbor should not be visible. Any idea how to find that out? waterfail