search

manifestinteractive / teleprompter

Browser-based TelePrompter with Remote Control
https://promptr.tv
Other
326 stars 115 forks source link

cookie storage dont works #4

Closed snchzantonio closed 3 years ago

snchzantonio commented 7 years ago

hi again, for some reason the cookie storage feature dont works, Have you thought about replacing it with other technology like localstorage?

manifestinteractive commented 7 years ago

Any change you have any error logs or messages being shown that you can share here ?

manifestinteractive commented 7 years ago

Also, I need to know details like what browser and operating system you are using. Plus version numbers of both. I need to know what you were using to make sure I can test this properly.

snchzantonio commented 7 years ago

my apologies, I`m newbie in this:

i dont make any changes to the save feature (even touch it)

No message appears on the console

windows 10 pro 64bit chrome 55 keyboard layout: ESP-ES (Spanish, Venezuela)

aaronpk commented 5 years ago

Cookies have a maximum size. I've noticed that when I paste in a large document, it just silently fails. I'm guessing that's what's happened here.

I'm considering switching this to use LocalStorage to store the text instead.

manifestinteractive commented 5 years ago

@aaronpk localStorage would be pretty sweet. It was still not 100% covered 4 years ago when I started this, but it is now. Pretty much all devices should support this, including mobile ( which was the main one that was giving me troubles for support in the beginning ).

aaronpk commented 5 years ago

Browser support is great now! https://caniuse.com/#feat=namevalue-storage

I'll work on a PR for this separately then. I'll just use the LocalStorage API directly to avoid pulling in a new library.

manifestinteractive commented 3 years ago

This was resolved a bit ago and never closed. v1.1.0 updated to use Local Storage and port over any existing cookies that users might have had.