search

manifold-lang / manifold-frontend

Frontend compiler for Manifold high-level language
GNU General Public License v3.0
6 stars 6 forks source link

addEdge check - endpoints exist #58

Closed maxqchen closed 9 years ago

maxqchen commented 9 years ago

addEdge check - endpoints exist

Fixes #50

maxqchen commented 9 years ago

Oh wow Intellij's create pull request thing worked. That's so cool.

maxqchen commented 9 years ago

Bah checkstyles. I thought we were at 120 characters? (or maybe that was just in core). Shall I change this to 120 as well?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.24%) when pulling c25e1d56983ca90f4d667193aed7c8de257895b4 on maxqchen:master into 150119034ac6ae96e89579b4cf9df16f5cdce69a on manifold-lang:master.

lucaswoj commented 9 years ago

Almost there! The changes shouldn't take more than 10 mins.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.29%) to 19.67% when pulling f395925b42ce005ac2325c0e779906712ef800c1 on maxqchen:master into 150119034ac6ae96e89579b4cf9df16f5cdce69a on manifold-lang:master.

mtrberzi commented 9 years ago

Hey Max! We talked about the correct cases for this offline, so once the test cases are there, I'll review this again.

maxqchen commented 9 years ago

Do you mean the tests lucas mentioned? There is a new diff that added them.

On Mon, Jan 26, 2015, 8:53 PM Murphy Berzish notifications@github.com wrote:

Hey Max! We talked about the correct cases for this offline, so once the test cases are there, I'll review this again.

— Reply to this email directly or view it on GitHub https://github.com/manifold-lang/manifold-frontend/pull/58#issuecomment-71576675 .

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.29%) to 19.67% when pulling 501f07513a0d38d6422ae198575ef7478fd57a29 on maxqchen:master into 150119034ac6ae96e89579b4cf9df16f5cdce69a on manifold-lang:master.

mtrberzi commented 9 years ago

Looks good OK to ship!