Check that variable assignments only have a single incoming edge

manifold-lang / manifold-frontend

Frontend compiler for Manifold high-level language

GNU General Public License v3.0

6 stars 6 forks source link

Check that variable assignments only have a single incoming edge #59

Closed maxqchen closed 9 years ago

maxqchen commented 9 years ago

WIP still! Just want to make sure the logic is correct before I start writing tests. Also is there a good Exception for this case? I just threw in RTE for it to compile but I'm sure there's something better. Maybe something we catch and use the list of strings to print a helpful error message?

issue #51

lucaswoj commented 9 years ago

Logic looks good. :ship: when checkstyle is satiated.

lucaswoj commented 9 years ago

We don't have a great system for custom exceptions yet. Just do whatever you think makes sense :+1: Someday we can go back and look for patterns to make them more consistent.

mtrberzi commented 9 years ago

I haven't forgotten -- I'll review this once the build passes.

coveralls commented 9 years ago

Coverage decreased (-0.1%) to 18.29% when pulling 3ff210d740e27793f4e5160415644bb5d61105c5 on maxqchen:51-all-vars-single-assignment into 150119034ac6ae96e89579b4cf9df16f5cdce69a on manifold-lang:master.

mtrberzi commented 9 years ago

Looks good, go ahead for ship!