search

manifold-lang / manifold-frontend

Frontend compiler for Manifold high-level language
GNU General Public License v3.0
6 stars 6 forks source link

#56 Adding subgraph to graph #63

Closed maxqchen closed 9 years ago

maxqchen commented 9 years ago

Throwing up some code for PR first, will update PR with tests once the function itself is good :)

maxqchen commented 9 years ago

ERMERGARD no checkstyle fails!

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.17%) to 18.44% when pulling c49effbafec369609c7e2c2aad3c99694dc168a4 on maxqchen:master into fd363f9fdf1545741a3faba218b7e911665f392d on manifold-lang:master.

mtrberzi commented 9 years ago

I think this is okay, but you'll want to test it first.

maxqchen commented 9 years ago

Updated with (hopefully) fix, added basic test.

Also I think there's a bug in FunctionTypeValueVertex, not sure though.

mtrberzi commented 9 years ago

This seems right?? I'm kind of not thinking clearly right now, but I would like you to at least address the comments I did make before I review again.

maxqchen commented 9 years ago

Passing in edges and deleting the main graph node / edges as discussed.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.54%) to 22.14% when pulling 3d8432f0d40cce0d56ed257c7bb9baaebb1b7fc2 on maxqchen:master into fd363f9fdf1545741a3faba218b7e911665f392d on manifold-lang:master.

maxqchen commented 9 years ago

This has a new diff if that didn't send out an email earlier.

mtrberzi commented 9 years ago

Okay, I think this is fine now.

maxqchen commented 9 years ago

Cool. What do we need next? The scope name transformation code?

mtrberzi commented 9 years ago

I was thinking about that last night -- the actual thing that is next is building function bodies. My PR for graph-building makes function values hold a subgraph instead of a list of expressions. Once that is ready, we can transform scope names (which I'm pretty sure interacts correctly with things like recursive function calls).

On Sun, Mar 15, 2015 at 1:15 AM, Max Qitian Chen notifications@github.com wrote:

Cool. What do we need next? The scope name transformation code?

— Reply to this email directly or view it on GitHub https://github.com/manifold-lang/manifold-frontend/pull/63#issuecomment-80863521 .