search

manifold-lang / manifold-frontend

Frontend compiler for Manifold high-level language
GNU General Public License v3.0
6 stars 6 forks source link

Primitive nodes with attributes aren't put into the schematic with those attributes #70

Open mtrberzi opened 9 years ago

mtrberzi commented 9 years ago

For example, register = primitive node (initialValue: Bool, resetActiveHigh: Bool, resetAsynchronous: Bool, clockActiveHigh: Bool, clock: digitalIn, reset: digitalIn, in: digitalIn) -> (out: digitalOut); only gets the digitalIn and digitalOut ports in the schematic, not the Bool attributes.

maxqchen commented 9 years ago

I tried reproducing this straight from a schematic -> serialize path and couldn't. After adding a bool attribute to the node type and a bool value to the node value, I got this:

 "in_node_name": {
      "attributes": {
        "inNodeAttr": "Bool"
      },
      "ports": {
        "in_port_name": "digital_in"
      }
    }
...
"nIN": {
      "type": "in_node_name",
      "attributes": {
        "inNodeAttr": "true"
      },
      "portAttrs": {
        "in_port_name": {}
      }
    },
mtrberzi commented 9 years ago

But is that in the schematic, or are you invoking the frontend? I think this is a frontend problem.

On Thu, Mar 19, 2015 at 11:16 PM, Max Qitian Chen notifications@github.com wrote:

I tried reproducing this straight from a schematic -> serialize path and couldn't. After adding a bool attribute to the node type and a bool value to the node value, I got this:

"in_node_name": { "attributes": { "inNodeAttr": "Bool" }, "ports": { "in_port_name": "digital_in" } } ... "nIN": { "type": "in_node_name", "attributes": { "inNodeAttr": "true" }, "portAttrs": { "in_port_name": {} } },

— Reply to this email directly or view it on GitHub https://github.com/manifold-lang/manifold-frontend/issues/70#issuecomment-83869617 .

maxqchen commented 9 years ago

Yeah that was built from the schematic. Just confirming it wasn't a core issue.