search

manifoldco / go-manifold

Go client API for Manifold (unstable)
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Quick fix to have the categories table work with idtypes #115

Closed Minivera closed 5 years ago

Minivera commented 5 years ago

See the code for why this was necessary, the idtype's Collection() method is used to find the database table and its ability to find the table's name is very limited. Since the Categories table was our first table to not have a simple "add a s" plural name, we never noticed the issue.

codecov[bot] commented 5 years ago

Codecov Report

Merging #115 into master will increase coverage by 0.33%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   39.33%   39.67%   +0.33%     
==========================================
  Files          20       20              
  Lines        2316     2329      +13     
==========================================
+ Hits          911      924      +13     
  Misses       1364     1364              
  Partials       41       41
Impacted Files Coverage Δ
idtype/idtype.go 85.71% <100%> (+2.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c427f6...796a257. Read the comment docs.