search

manifoldco / go-manifold

Go client API for Manifold (unstable)
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Initial introduction of generated api client #25

Closed jbowes closed 7 years ago

jbowes commented 7 years ago

Supports only identity and catalog now, but its a start!

tim-speed commented 7 years ago

What's the benefit of this? Just moving the specs out of Marketplace to this shared library? Looks fine to me.

jbowes commented 7 years ago

What's the benefit of this?

zz_oag_generated_identity.go and zz_oag_generated_catalog.go, which provide an api for speaking to those two services. And maybe i'm biased, but it's a pretty nice API, too!

tim-speed commented 7 years ago

Totally biased, but I agree it's a pretty nice API :) Like Jelmer mentioned, are we going to get a zz_oag_generated_marketplace.go?

jbowes commented 7 years ago

Like Jelmer mentioned, are we going to get a zz_oag_generated_marketplace.go?

yes, but not yet. needs https://github.com/jbowes/oag/issues/10 first :(

jbowes commented 7 years ago

It looks like not all specs get generated files. What's the reason for putting it in the repo if it's not generated?

Just so its easier to take the specs out of our internal repo and bring them over here. That's also why some things are in the specs that shouldn't be/don't need to be: its a bug in the original spec's audience, or a bug in our processor.

jbowes commented 7 years ago

marketplace added, too!