search

manifoldco / go-manifold

Go client API for Manifold (unstable)
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

update marketplace spec to generated proper error handling #57

Closed domenicrosati closed 6 years ago

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

jbowes commented 6 years ago

I'd stick with Unexpected as the returned type. The specs in this repo should match those that we have internally. they're only duplicated here to aid in building the code; they shouldn't drift or change the api.

jelmersnoeck commented 6 years ago

So this shouldn't be Error? (which it currently seems to be)

We'll have to add the Unexpected response in the spec and use that as the default.

domenicrosati commented 6 years ago

@jelmersnoeck can do