search

manifoldco / go-manifold

Go client API for Manifold (unstable)
https://www.manifold.co
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Adds format validation for credential keys and body #92

Closed Minivera closed 5 years ago

Minivera commented 5 years ago

When sending requests to put credentials inside the partners API, we want to make sure those credentials are within the system limits for environment variables. These changes add a basic check for credential keys and bodies, more checks will be needed on marketplace's side.

codecov[bot] commented 5 years ago

Codecov Report

Merging #92 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   40.88%   41.12%   +0.23%     
==========================================
  Files          17       17              
  Lines        2003     2011       +8     
==========================================
+ Hits          819      827       +8     
  Misses       1152     1152              
  Partials       32       32
Impacted Files Coverage Δ
formats.go 88.88% <100%> (+3.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e542a48...c1174bf. Read the comment docs.